Trim SQL statements #962
Closed
Trim SQL statements #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
force-pushed
the
trim-statements
branch
from
234d623 to
5c89e0a
Compare
Open
Indeed, the ADO.NET conformance tests found a problem: executing the command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #961.
This trims the SQL (from
MySqlCommand.CommandText) for non-prepared commands before sending it to the server for execution.This matches the behaviour of
MySqlCommand.Prepare()better, as well as matching Connector/NET's behaviour in some trivial cases.It does add some increased risk that unusual SQL will be transformed/truncated by this new code and thus introduce new bugs.